Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use submodule nph in CI to check lint #2988

Closed
wants to merge 6 commits into from
Closed

chore: use submodule nph in CI to check lint #2988

wants to merge 6 commits into from

Conversation

fryorcraken
Copy link
Collaborator

No description provided.

@fryorcraken fryorcraken requested a review from a team August 20, 2024 05:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2988

Built from aefd6e7

gabrielmer
gabrielmer approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Ivansete-status
Copy link
Collaborator

Morning @fryorcraken!
nph v0.6.0 doesn't impose a particular NimPatch version. Maybe we could use that one: https://github.com/arnetheduck/nph/blob/v0.6.0/src/nph.nim

As a reminder for other readers, we currently use Nim compiler v2.0.8 to build nwaku.

@fryorcraken fryorcraken mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@gabrielmer gabrielmer gabrielmer approved these changes

Assignees

@fryorcraken fryorcraken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fryorcraken @Ivansete-status @gabrielmer